- Code Review, n: A masochistic process that makes you feel the pain of bad code yourself instead of going the much easier way of passing it on to the customer.
- Code Reviews – because it's a good feeling to see that you aren't the only one who makes obvious mistakes.
- Code Review Bullshit Bingo with 5x5 cells and entries like:
- Silent catch
- Extensive usage of Copy & Paste
- Local temp file accidentally checked in
- Tabs instead of spaces
- Same error still exists in third review round
- Function with more than 100 lines
- Line with more than 100 characters
- Code review with more than 100 files
- Global variable
- Inheritance instead of composition
- Return -1 instead of throwing Exception
- Missing unit tests
- Hardcoded file path of developer's PC
- ...
- Comic with two people talking:
A: "I am the only one in my company who can maintain my component!"
B: "Why, are you that smart?"
A: "No, the code is that ugly."
Wednesday, July 12, 2017
From an idea brainstorming for "T-shirts about Code Review"
Subscribe to:
Post Comments (Atom)
No comments:
Post a Comment